On Tue, Nov 29, 2011 at 7:29 AM, Andrew Petro <ape...@unicon.net> wrote:
> Scott, > > > update the patch to remove the now unnecessary code that displays the > message [that displays on the services management page in the case where > zero services are registered] > > This pull request [1] doesn't change the CAS behavior of defaulting to any > service can use cas when zero services are registered. The > auto-registration behavior will fire only in the case where access to an > auto-register-able (by default, the services management application) > service would otherwise fail for lack of that service being registered. In > the case where zero services are registered, the CAS services registry will > permit use of CAS to authenticate to the services management service, so > the auto-registration behavior doesn't fire. > The message explicitly tells you to add it, yet we've defaulted to allowing it to pass through without being added. That's confusing and misleading at this point. (we also don't default to open access any more, which if that message references it, means its even more out of date!) > > I think that, in the case where zero services are registered, the services > management tool should still display a message explaining the special > behavior when zero services are registered, to help CAS administrators > better understand what they're managing. > > That is, I'd favor updating the value of that message rather than removing > it entirely. > > The problem is the message goes away when you add a service, not when you finally register the Services Management Tool. > I took a shot [2] at composing an updated value for > > management.services.service.warn > > and used Google Translate to produce values for the more achievable of the > non-English localizations, some of which did not yet have this key. > > I see I've mangled a commit [2] again, touching a bunch of lines I didn't > mean to be touching. Any idea what's going on here? I took some care to > review the changes in IntelliJ before committing them, and I'd swear > IntelliJ didn't show all those non-desirable touched lines [3]. > > I'll have to apply additional commits to this pull request correcting this > to only add the new key and not touch the rest of these message files, once > I understand what's with my editing practices. > There's always been some issues with the special characters. Which is why some of them have been run through the native2ascii tool. I can run them all through that before you make any changes, but it makes it harder to figure out what the messages are. Cheers, Scott > > Andrew > > > > [1]: https://github.com/Jasig/cas/pull/12 > > [2]: > https://github.com/apetro/cas/commit/e3e3d4555006644f403c93a49a8bbf8946cdf6b5 > > [3]: http://www.flickr.com/photos/microcline/6424492305/ > > > > On 11/12/2011 11:05 PM, Scott Battaglia wrote: > > Andrew, can you update the patch to remove the now unnecessary code that > displays the message? > > Or do people want it in there still? > > Cheers, > Scott > > On Fri, Nov 11, 2011 at 9:38 AM, Scott Battaglia < > scott.battag...@gmail.com> wrote: > >> At a high level it looks good. I'll take a quick look at it tonight. >> >> Two comments though from a feature perspective: >> 1. If we do this we should revisit the message that display on the manage >> page. >> 2. This should really not happen if the services management tool isn't >> using CAS. >> >> >> On Fri, Nov 11, 2011 at 9:28 AM, Marvin Addison <marvin.addi...@gmail.com >> > wrote: >> >>> > https://issues.jasig.org/browse/CAS-1067 >>> >>> I commented on the pull and on the issue. Looks good to me. Nice work, >>> Andrew. >>> >>> Seems like a good time to mention we need to track _all_ non-trivial >>> pull requests via Jira issues. If there's any doubt whether a pull is >>> trivial, create an issue to be safe. While code review can naturally >>> happen on the pull itself on the GitHub side, we need a Jira issue to >>> track the link to the pull and capture any important discussion so >>> that these changes appear in the changelog at release time. >>> >>> M >>> >>> -- >>> You are currently subscribed to cas-dev@lists.jasig.org as: >>> scott.battag...@gmail.com >>> To unsubscribe, change settings or access archives, see >>> http://www.ja-sig.org/wiki/display/JSG/cas-dev >>> >> >> > -- > You are currently subscribed to cas-dev@lists.jasig.org as: ape...@unicon.net > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-dev > > > -- > You are currently subscribed to cas-dev@lists.jasig.org as: > scott.battag...@gmail.com > > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-dev > > -- You are currently subscribed to cas-dev@lists.jasig.org as: arch...@mail-archive.com To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
