I've fixed your permissions. In general, however, if you've issued a pull request, someone else should push it in order for a code review to occur.
We should all become more stringent about getting another pair of eyes on code we commit (that includes me as I am probably one of the main culprits out of habit to committing directly ;-)). On Mon, Dec 19, 2011 at 12:36 PM, Andrew Petro <ape...@unicon.net> wrote: > This pull request > > https://github.com/Jasig/cas/pull/15 > > is intended to partially address some of Scott Battaglia's comments [1] > about pull request 11 [2], which added EhCache ticket registry to > Jasig/cas/master (towards CAS 3.5, CAS-1076 [3]). > > I'd push pull request 15 myself, but apparently I lack privileges to push > to Jasig/cas > > Anyone able to fix my GitHub permissions such that I can push this staged > change set? > > Andrew > > [1]: > https://github.com/atilling/cas/commit/d2a27f8d4465bf226c1fe17ba17e82c828145fb9 > > [2]: https://github.com/Jasig/cas/pull/11 > > [3]: https://issues.jasig.org/browse/CAS-1076 > > On Dec 5, 2011, at 5:47 PM, Scott Battaglia wrote: > > > I posted comments. It was not ready to be merged in. Unless there were > changes between the original pull request and the code in master. > > > > Cheers, > > Scott > > > > > > On Mon, Dec 5, 2011 at 5:30 PM, William G. Thompson, Jr. < > wgt...@gmail.com> wrote: > > On Mon, Dec 5, 2011 at 4:52 PM, Scott Battaglia > > <scott.battag...@gmail.com> wrote: > > > Was the contribution code reviewed before being pulled in to master? > > > > Yes, I looked it over before pulling into master. > > > > > > > > I believe Marvin said he was going to code review it (and I'm willing > to > > > also if Marvin hasn't completed it yet). > > > > Great. > > > > Bill > > > > > > > > > > > > > > > On Mon, Dec 5, 2011 at 4:44 PM, William G. Thompson, Jr. < > wgt...@gmail.com> > > > wrote: > > >> > > >> Folks, > > >> > > >> FYI. feature-lppe branch as the latest from AndrewT. I also pulled > > >> in the ehcache module into master...looks like some of the test code > > >> might need to be moved around, but the code is looking pretty good. > > >> > > >> Bill > > >> > > >> -- > > -- > You are currently subscribed to cas-dev@lists.jasig.org as: > scott.battag...@gmail.com > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-dev > > -- You are currently subscribed to cas-dev@lists.jasig.org as: arch...@mail-archive.com To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
