Thanks. See this please: https://issues.jasig.org/browse/CAS-1196
-Misagh From: Scott Battaglia [mailto:[email protected]] Sent: Sunday, October 07, 2012 10:45 AM To: [email protected] Subject: Re: [cas-dev] CASImpl: Misleading javadocs? The javadoc was most likely written before we decided to delegate one method to the other. If you open a JIRA issue, I'll update the javadoc and send a pull request. Thanks! Scott On Wed, Sep 26, 2012 at 10:36 AM, Misagh Moayyed <[email protected]> wrote: Team, While looking at CentralAuthenticationServiceImpl.java, I noticed something strange. There are two overloaded methods for grantServiceTicket(). - The one that accepts 'credentials' says in its javadocs: 'throws IllegalArgumentException if TicketGrantingTicket ID, Credentials or Service are null.' [1] - The one that does not accept 'credentials' passed null instead. No exceptions are thrown. [2] I am guessing the docs are misleading. Could someone confirm plz? [1] https://github.com/Jasig/cas/blob/master/cas-server-core/src/main/java/org /jasig/cas/CentralAuthenticationServiceImpl.java#L181 [2] https://github.com/Jasig/cas/blob/master/cas-server-core/src/main/java/org /jasig/cas/CentralAuthenticationServiceImpl.java#L274 -Misagh -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
