Merged with master under a second pull:
https://github.com/Jasig/cas/pull/171



Regards,

-Misagh





From: Misagh Moayyed [mailto:[email protected]]
Sent: Tuesday, November 13, 2012 4:10 PM
To: '[email protected]'
Subject: Review of LPPE Changes under Pull #153



Team,

I’d like to invite review of pull #153 that addresses a number of
LPPE-related enhancements:

https://github.com/Jasig/cas/pull/153



The changeset includes internalizing ldap error codes, taking advantage of
existing ldap authN handlers, support for custom attribute that determine
account state, fixes to the LPPE UI that were broken in style after the
recent responsive UI design change and general cleanup and javadocs. I’d
very much like to get the changeset in so that early adopters can review
and provide feedback, especially those that are behind open ldap.



Jérôme did a preliminary review and a number of comment were addressed and
fixed in the pull. If you have time and do get a chance, please take a
look and suggest improvements where needed. I am hoping that we might be
able to merge towards end of the next week if not earlier.



Regards,

-Misagh




-- 
You are currently subscribed to [email protected] as: 
[email protected]
To unsubscribe, change settings or access archives, see 
http://www.ja-sig.org/wiki/display/JSG/cas-dev

Reply via email to