Scott, Appreciate the review. That certainly makes sense! I'll adjust based on your feedback and resubmit the pull. :)
Regards -Misagh From: Scott [mailto:[email protected]] Sent: Tuesday, December 11, 2012 11:58 AM To: [email protected] Subject: Re: [cas-dev] Review of dotnet CAS client's pending pulls Hi Misagh, I took a look at the commits. NETC-47 looks good. I had 1 comment on UrlUtil.cs in NETC-46 that might be worth considering. It looks like you are dynamically changing the proxy callback URL scheme based on whether the current request is http or https. I think you should just stick with exactly what's in the config in case the port numbers are non-standard. Changing http://site.fqdn.com:1234/ to https://site.fqdn.com:1234/ dynamically will definitely break things and changing http://site.fqdn.com/ to https://site.fqdn.com/ may or may not. Another thing that jumped out at me, though I could be wrong... if the SSL communication from the CAS server to the website is configured properly, the proxy callback should be fine over https even if the request that initiated the proxy ticket request was not. Does that make sense? I always thought of the callbacks as completely separate request, independent of the outbound requests that triggered them. -Scott On Tue, Dec 11, 2012 at 11:26 AM, Misagh Moayyed <[email protected]> wrote: Team, There are a couple pending pulls on the dotnet CAS client dating back to a couple of months ago: Proxy Callback support: https://github.com/Jasig/dotnet-cas-client/pull/3 ClearPass support: https://github.com/Jasig/dotnet-cas-client/pull/4 I'd like to go ahead and merge these preferably by EOD if there are no outstanding comments or objections. Please review when you get a chance. Thanks, -Misagh -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
