Ok, interesting. The delete method should not delete. This is slightly insane, and MemCacheTicketRegistry does not work that way, it sure deletes. The contract again:
/** * Remove a specific ticket from the registry. * * @param ticketId The id of the ticket to delete. * @return true if the ticket was removed and false if the ticket did not * exist. */ boolean deleteTicket(String ticketId); It cannot be more specific. Delete should remove the ticket. Nothing in there about expiration. If something is requesting the ticket after TicketRegistry.delete is called that something is broken, not your ticket registry. Or else, the TicketRegistry interface is completely botched. This area seems utterly confused right now. Best regards, /Fredrik 1 feb 2013 kl. 10:54 skrev Alexandre DE PELLEGRIN <depelleg...@essec.edu> : > Hi Fredrik, > > Just my little tips for your implementation. The "delete" method > should not remove the element from the registry. I realized it because > I use an EHCache full memory implementation replicated with JGroups > extension between nodes and I've just discovered that the audit module > can request TGT on logout action after the 'delete' method cas call. > So, I fixed my implementation to only expire EHCache elements. I also > changed my 'getTicket' method to only return non expired elements. > BTW, it is very important to understand that ticket expiration is > different than ticketregistry element expiration. > > Best regards, > Alexandre de Pellegrin > > 2013/2/1 Fredrik Jönsson <f...@kth.se>: >> Sorry for spamming the list lately, but we will soon be upgrading our CAS >> implementation at KTH with 3.5.x. For this update we are developing a >> Couchbase (www.couchbase.com) cluster aware ticket registry and service >> registry with the intention of eventually provide a redundant SSO-solution >> based on the cluster capabilities in Couchbase, though this is untested and >> will not be a part of the initial deployment this spring. >> >> Our CouchbaseTicketRegistry is essentially a minor modification of >> MemcacheTicketRegistry, we are not converting tickets to JSON at this point >> but storing them as opaque serialized objects. It does however use couchbase >> view functionality in order to support the statistics page with information >> not easily realized with just memcache. Our CouchbaseServiceRegistryDaoImpl >> stores service information as Json. We'd be happy to share this in case >> someone is interested, just drop me a note. >> >> Best regards, >> /Fredrik >> >> -- >> Fredrik Jönsson, M.Sc. Email: f...@kth.se >> System architect Phone: +46 8 790 66 >> 03 >> Kungliga tekniska högskolan (KTH) Mobile: +46 73 595 66 03 >> KTH/UF/ITA/Infosys >> >> >> -- >> You are currently subscribed to cas-dev@lists.jasig.org as: >> depelleg...@essec.edu >> To unsubscribe, change settings or access archives, see >> http://www.ja-sig.org/wiki/display/JSG/cas-dev >> > > > > -- > Architecte Solutions Innovantes > Groupe ESSEC > Avenue Bernard Hirsch-B.P.50105 > 95021 Cergy-Pontoise Cedex France > Tel : +33.1.34.43.36.36 > Mail : depelleg...@essec.edu > > -- > You are currently subscribed to cas-dev@lists.jasig.org as: f...@kth.se > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-dev > -- You are currently subscribed to cas-dev@lists.jasig.org as: arch...@mail-archive.com To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev