Dear Jérôme, Thanks for removing the final keyword so that I can extend from it. The problem is that our CAS clients are scattered around and not central managed. That makes change management a big problem to us.
Regards, -Ken On Mon, Apr 22, 2013 at 8:16 PM, jleleu <[email protected]> wrote: > Hi, > > I'm not sure to understand why it causes you such a "big problem". Why not > keeping the typed identifier as is ? Even the parsing is pretty simple if > needed and using typed identifiers will avoid identifier collisions. > > I'm not in favor of having an additionnal behaviour here to just return > identifiers instead of typed identifiers. It sounds too specific to me. I > may change my mind if someone else raise objections. > > That said, the source code of the ClientCredentialsToPrincipalResolver is > really simple [1] and it should be easy to create a new one to match your > expectations. I will remove the final keyword so you can inherit from it. > > Best regards, > Jérôme > > [1] > https://github.com/Jasig/cas/blob/master/cas-server-support-pac4j/src/main/java/org/jasig/cas/support/pac4j/authentication/principal/ClientCredentialsToPrincipalResolver.java > > -- > You are currently subscribed to [email protected] as: > [email protected] > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-dev > -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
