It has many impacts as the httpClient is now injected in the LogoutManagerImpl and no more in argument extractors and services classes. I think it improves the general design of logout in the source code.
I think I'm going to like that change as well.
2) when to find if the service is back or front SLO... This can be computed using the servicesManager bean : - at service creation (in the argument extractors) - at logout (in the logout manager) : this is what I implemented. I made this choice because I think that the logout type makes more sense at logout.
Sounds reasonable. I'll review the pull today or tomorrow and provide some thoughtful feedback.
M -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
