Hi Marvin,

Unfortunately, I haven't been able to reproduce this specific error.

I do have an error on the same test class, both on tag v3.5.2 and branch
3.5.3-SNAPSHOT (there was no change on the cas-server-support-oauth module
since the release):
*org.scribe.exceptions.OAuthException: Response body is incorrect. Can't
extract token and secret from this: 'SSL is required'*
* at
org.scribe.extractors.TokenExtractorImpl.extract(TokenExtractorImpl.java:41)*
It's due to a change at Twitter to force the use of SSL.

I patched the branch 3.5.3-SNAPSHOT:
https://github.com/Jasig/cas/commit/580567485647010a89b07ecccfe40170071ae2a4,
which fixed the build:
https://developer.jasig.org/bamboo/browse/CAS3-TIB-390.
This is exactly the same fix I applied on the tag v3.5.2 to make it build
also.

Would you mind checking the issue reported on your build and maybe trying
my fix?

Thanks.
Best regards,
Jérôme



2014-02-24 18:24 GMT+01:00 Marvin Addison <[email protected]>:

> I'm working on a 3.5.2.1 patch release and I'm getting the following test
> error:
>
>
> -------------------------------------------------------------------------------
> Test set: org.jasig.cas.support.oauth.web.OAuth10LoginControllerTests
>
> -------------------------------------------------------------------------------
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.186
> sec <<< FAILURE!
> testOK(org.jasig.cas.support.oauth.web.OAuth10LoginControllerTests)
> Time elapsed: 0.186 sec  <<< ERROR!
> java.lang.IllegalArgumentException: Cannot get String from a null object
>   at org.scribe.utils.Preconditions.check(Preconditions.java:82)
>   at org.scribe.utils.Preconditions.checkNotNull(Preconditions.java:29)
>   at org.scribe.utils.StreamUtils.getStreamContents(StreamUtils.java:20)
>   at org.scribe.model.Response.parseBodyContents(Response.java:41)
>   at org.scribe.model.Response.getBody(Response.java:67)
>   at
> org.scribe.up.addon_to_scribe.ProxyOAuth10aServiceImpl.getRequestToken(ProxyOAuth10aServiceImpl.java:68)
>   at
> org.scribe.up.provider.BaseOAuth10Provider.getAuthorizationUrl(BaseOAuth10Provider.java:56)
>   at
> org.jasig.cas.support.oauth.web.OAuth10LoginController.handleRequestInternal(OAuth10LoginController.java:55)
>   at
> org.springframework.web.servlet.mvc.AbstractController.handleRequest(AbstractController.java:153)
>
> Can someone check out v3.5.2 and investigate?
>
> Thanks,
> M
>
> --
> You are currently subscribed to [email protected] as:
> [email protected]
> To unsubscribe, change settings or access archives, see
> http://www.ja-sig.org/wiki/display/JSG/cas-dev
>

-- 
You are currently subscribed to [email protected] as: 
[email protected]
To unsubscribe, change settings or access archives, see 
http://www.ja-sig.org/wiki/display/JSG/cas-dev

Reply via email to