Also, I realize now it makes better sense for the build to check for commit messages and adherence to other conventions *after* it's been able to successfully build and test the pull. We would have been able to capture the failure in advance.
> -----Original Message----- > From: Misagh Moayyed [mailto:[email protected]] > Sent: Wednesday, April 02, 2014 12:02 PM > To: [email protected] > Subject: RE: [cas-dev] [cas-user] Schedule for CAS 4.0 > > Another issue; pull #415 [1] broke the following test in cas-server-core: > MultifactorAuthenticationTests#testAllowsAccessToHighSecurityServiceWithPa > sswordAndOTPViaRenew() > > This is where the test failure comes from: > > if (!(current.getPrincipal().equals(original.getPrincipal()) > && current.getAttributes().equals(original.getAttributes()))) { > throw new MixedPrincipalException(current, current.getPrincipal(), > original.getPrincipal()); } > > The comparison on authentication attribute fails. What is the intention here? > Should the principal attributes be compared if we are checking for mixed > principal conditions? If so, should that just be captured inside the > equals() of SimplePrincipal? > > [1] https://github.com/Jasig/cas/pull/415 > > > -----Original Message----- > > From: Misagh Moayyed [mailto:[email protected]] > > Sent: Wednesday, April 02, 2014 10:10 AM > > To: '[email protected]' > > Subject: RE: [cas-dev] [cas-user] Schedule for CAS 4.0 > > > > Excellent. I'll get going. > > > > > -----Original Message----- > > > From: Marvin Addison [mailto:[email protected]] > > > Sent: Wednesday, April 02, 2014 10:04 AM > > > To: [email protected] > > > Subject: Re: [cas-dev] [cas-user] Schedule for CAS 4.0 > > > > > > > Thanks. Keep us posted on the progress please. > > > > > > Ldaptive 1.0.3 has been released and is available in Maven Central > > > [1], so we should be good to bump the version and move forward. > > > > > > M > > > > > > http://search.maven.org/#artifactdetails%7Corg.ldaptive%7Cldaptive%7 > > > C1 > > > .0.3%7C > > > jar > > > > > > -- > > > You are currently subscribed to [email protected] as: > > > [email protected] To unsubscribe, change settings or access > > > archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev > > -- > You are currently subscribed to [email protected] as: > [email protected] To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-dev -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
