Team,
There has been much discussion around reducing the complexity that is now carried by CASImpl. I'd say that simply the ability to remove from CASImpl the mapping between services and ticketed generators would be great improvement [1]. Presently, custom service extensions are sort of forced to register their own ticket id generator, even if they don't really care for one per se. Furthermore, I have been reminded that removing this configuration from CASImpl would allow our service layer to remain as pure as possible without having any knowledge of the protocol-specific functionality. So, I had in mind that instead of what exists today, every service created by argument extractors would carry/register a default ticket id generator, something like this: service.getTicketIdGenerator().generateTicket(.) .which would remove the need to register one explicitly, of course can be overridden if need be. Now since services are actually created by argument extractors, this would require that each argument extractor expose a parameter so that a ticketid generator be injected in. So the turn of events would be: 1. Argument Extractor (AE) is injected with ticketid generator X 2. AE attempts to extract the service, by calling SomeService.createService(X) 3. SomeService creates the service initialized with X I would like to eliminate step #2, and actually allow the argument extractor itself to do the thing it says it should, which is the extraction of the service. The flow would be: 1. Argument Extractor (AE) is injected with ticketid generator X 2. AE attempts extracts the service initialized with X Here is a pull request that attempts to do that: https://github.com/Jasig/cas/pull/698 We have been reviewing the exact meaning of the pull and its pros and cons and it has sort of gone stale. I would like us to come to a decision about the fate of this change, whether there is anything I can help with. I am not really sure where to go from here. So some guidance/clarification would be very helpful. [1] https://github.com/Jasig/cas/blob/master/cas-server-core/src/main/java/org /jasig/cas/CentralAuthenticationServiceImpl.java#L130 -- You are currently subscribed to cas-dev@lists.jasig.org as: arch...@mail-archive.com To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
