Team,

 

Working on this issue: https://github.com/Jasig/cas/issues/866

 

As it turns out, the error message is hardcoded into the message bundle,
which assumes CAS protocol. In order to get around this, I thought I could
modify every extractor (about 3-4) to communicate back the parameters it
uses for parsing the request. So I defined a few methods for
AbstractArgumentExtractor to let individual extractors override them, and
then I realized, that extactors don't actually extract. They delegate that
logic over to each service which makes this approach unfeasible. 

 

So, unless anyone has any other suggestions for issue #866, I am inclined
to move the extraction logic from services and over to extractors to make
this work. Does that make sense? I know in the past we have had
reservations about making this sort of change, but this is almost the 3rd
time that I have bumped into an issue where the extractor->service
delegation isn't actually doing me any good. So I thought to raise the
question again and see if we get make the change. 

 

- Misagh


-- 
You are currently subscribed to [email protected] as: 
[email protected]
To unsubscribe, change settings or access archives, see 
http://www.ja-sig.org/wiki/display/JSG/cas-dev

Reply via email to