Hi, I saw his answer. I understand the concern and the need for consistency in CAS, but the same is worth for pac4j as well: I could change the default behavior in pac4j, but this would impact users just to accommodate with the consistency of CAS.
My feeling is that the default behavior of pac4j should be kept, but changed when used in CAS to have consistency in both systems (alone or bundle). Here is my proposal: by default, in CAS, the id,username,password attributes are defined, which makes things consistent in CAS: no need to define the attributes, consistent in pac4j and things will work properly. What do you think? Thanks. Best regards, Jérôme Le lun. 4 nov. 2019 à 09:51, Andy Ng <long...@gmail.com> a écrit : > Hi Jérôme, > > PR was declined because Moayyed considered this behavior as something need > to be fixed in pac4j, see this: > > Since defining attributes is necessary for pac4j to work when using > MongoDB Authentication, the attributes properties is necessary here. > However, this behavior of requiring attributes is different from other > authentication methods (e.g.JDBC), so I proposed to add an warning here for > clarity sake. See if agree. > > Thanks for the patch but none of this sounds right. > > Attribute support is always optional. All authentication methods in CAS > work with or without presence of attributes in the authentication source. A > design choice or limitation of a library should not have to contract > consistent behavior elsewhere. Changes need to be done on pac4j to allow > attribute-less authentication. > > > Should I bring this discussion to pac4j group instead? Thanks. > > Cheers! > - Andy > > -- > - Website: https://apereo.github.io/cas > - Gitter Chatroom: https://gitter.im/apereo/cas > - List Guidelines: https://goo.gl/1VRrw7 > - Contributions: https://goo.gl/mh7qDG > --- > You received this message because you are subscribed to the Google Groups > "CAS Community" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to cas-user+unsubscr...@apereo.org. > To view this discussion on the web visit > https://groups.google.com/a/apereo.org/d/msgid/cas-user/84c1396e-647e-484c-b2db-1325250b621f%40apereo.org > <https://groups.google.com/a/apereo.org/d/msgid/cas-user/84c1396e-647e-484c-b2db-1325250b621f%40apereo.org?utm_medium=email&utm_source=footer> > . > -- - Website: https://apereo.github.io/cas - Gitter Chatroom: https://gitter.im/apereo/cas - List Guidelines: https://goo.gl/1VRrw7 - Contributions: https://goo.gl/mh7qDG --- You received this message because you are subscribed to the Google Groups "CAS Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to cas-user+unsubscr...@apereo.org. To view this discussion on the web visit https://groups.google.com/a/apereo.org/d/msgid/cas-user/CAP279LyUrT6YWAhEaw83dOo9je%3DdUNDZhVttwjHyDKe541s6rQ%40mail.gmail.com.
