You have basically one large commit for all changes, its much easier for apereo to see what and where is being changed if you make a commit for each section of changes. Also, why is there authy stuff in the mfa module, should probably be renamed, the classes, etc.. to okta, for example, "package org.apereo.cas.adaptors.authy" is already used in cas, should be changed to probably something like "org.apereo.cas.okta" since it already exist and would stay in line with how modules are packaged, the config probably should be under "org.apereo.cas.config" and not be 'authyconfiguration'
On Friday, September 8, 2023 at 3:18:35 AM UTC-5 Jérémie wrote: > Hi, > > I have developped a custom module for Apereo CAS to allow Okta MFA support > for CAS Authentication > > We have developed a custom working module based on a similar Authy project > we've found online. > > We are having trouble now to fork, adapt & submit our module to CAS 6.6.12 > release due for the end of september. Our Pull Request has been > automatically rejected : https://github.com/apereo/cas/pull/5751/files > > I've never done that so I might not see obvious steps here. > > Thank you > -- - Website: https://apereo.github.io/cas - Gitter Chatroom: https://gitter.im/apereo/cas - List Guidelines: https://goo.gl/1VRrw7 - Contributions: https://goo.gl/mh7qDG --- You received this message because you are subscribed to the Google Groups "CAS Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to cas-user+unsubscr...@apereo.org. To view this discussion on the web visit https://groups.google.com/a/apereo.org/d/msgid/cas-user/71d7d4a4-2f7d-4a33-a88a-f6d0f27ce15bn%40apereo.org.
