[
https://issues.apache.org/jira/browse/CASSANDRA-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728178#action_12728178
]
Eric Evans commented on CASSANDRA-272:
--------------------------------------
First off, using objects named for the table instead of the column produces a
very readable layout in jconsole. That's a keeper. :)
A few things though:
The methods that were added to Table for the MBean are still there, can I get
you to resubmit the patch without those?
Since ColumnFamilyStore.getTableName() isn't actually used anywhere, it's
probably safe to assume that it isn't needed, can you remove that as well?
And on an OCD related front.... :)
NodeProbe is basically the place to query node-specific info, so it's probably
wise to avoid overly generic identifiers like "stats" that might conflict with
other statistics oriented instrumentation in the future. I think we should
rename the getStats() method to something like getColumnFamilyStats() instead.
I'm sure the same applies to the "stats" command argument, though I don't feel
as strongly about that one. If you wanted to rename it as well, maybe "dbstats"
or "cfstats"?
On a code style/consistency/readability front. NodeProbe.getStats() has some
unusually long lines, mostly caused by very long variable names like
"tableNameToColumnFamilyStoreMBean". These verbose/descriptive names are good
when used at the class/instance level or when appearing in a method signature,
but are less useful when the scope is local.
> Enhance how metrics are exposed
> -------------------------------
>
> Key: CASSANDRA-272
> URL: https://issues.apache.org/jira/browse/CASSANDRA-272
> Project: Cassandra
> Issue Type: New Feature
> Affects Versions: 0.3
> Reporter: Sammy Yu
> Assignee: Sammy Yu
> Priority: Minor
> Fix For: 0.3
>
> Attachments: 0001--Work-for-cassandra-272.patch,
> 0002--Work-for-cassandra-272.patch, 0003-Work-for-CASSANDRA-272.patch
>
>
> Had discussion on IRC about the metric interfaces that are used in the code
> today. There are two sets one using IAnalyticsSource to send data to
> Gangalia and another set of interface using JMX MBeans (ie,
> ColumnStoreFamily).
> Since FB is not using Gangalia anymore and it looks like the other
> VMAnalyticsSource is already available via JMX, we should prefer to expose
> metrics through JMX. I will add a new TableMBean which exposes the metrics
> in DBAnalyticsSource.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
