Hi Daniel, Thanks for the patch, however I had a look at it and it is not in the format we usually expect. Are you able to supply us with a .patch file? Have a look at http://www.castleproject.org/community/patch.html for instructions on how to create a patch. and have also a read about our coding standards (http://www.castleproject.org/community/codingstandards.html) You need to create a patch from our current trunk version.
A proper .patch file would help us a lot. Cheers John ________________________________ From: bdaniel7 <[email protected]> To: Castle Project Users <[email protected]> Sent: Wednesday, 29 July, 2009 5:42:57 PM Subject: Re: customized EnumToPairs Done. http://support.castleproject.org/projects/MR/issues/view/MR-ISSUE-544 I hope i did it right. btw, donjon looks very nice :) On Jul 28, 5:47 pm, Jonathon Rossi <[email protected]> wrote: > You can attach the patch to your email on this mailing list (or the > development mailing list), or submit it directly in our issue tracker. > > One comment I'll make is that I had no idea what EnumToPairs was until I > read the code, so maybe it needs a more descriptive name. > > > > On Wed, Jul 29, 2009 at 12:01 AM, bdaniel7 <[email protected]> wrote: > > > Hello, > > > Working for a Dutch customer, we needed a way to customize some enums, > > so that he sees the texts in Dutch and we work with the English member > > names. > > Therefore i added a Description attribute to each member of the enums. > > > public enum MaterialType > > { > > [Description( "Tegels" )] > > Tiles=1, > > [Description("Klinkers")] > > PavementStones > > } > > > these attributes are read by some extension methods. > > > So far, so good, but we needed a way to create the selects, options, > > radio/checkbox inputs with dutch texts as well. > > EnumToPairs is only using TextHelper.PascalCaseToWord which wasn't > > good enough. > > Therefore, I created a small patch (and a couple of tests) for > > EnumToPairs method, that can be used to invoke an extension method of > > the enum type. > > > I can submit the code for review and perhaps to be included in the > > official codebase. > > What do you say? > > -- > Jono ____________________________________________________________________________________ Access Yahoo!7 Mail on your mobile. Anytime. Anywhere. Show me how: http://au.mobile.yahoo.com/mail --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Castle Project Users" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/castle-project-users?hl=en -~----------~----~----~----~------~----~------~--~---
