This one time, at band camp, Hiran Chaudhuri said:
HC>This time I'm tried to get the CVS version (pulled today) of Castor running
HC>with the Tamino SQL engine. I'll tell you what I had to change hoping that
HC>you might commit such changes and future versions of Castor support Tamino
HC>out of the box.
HC>
HC>1. Adapted create.sql to TaminoSQL.sql to create the database
HC>2. Changed database.xml to use the Tamino SQL driver and my db connection
HC>3. Modified castor.properties to support the taminosql engine
HC>4. Added classes TaminoSQLQueryExression and TaminoSQLFactory
HC>5. Added the Tamino JDBC driver to the classpath (not added to this mail)
HC>6. Changed SQLRelationLoader to escape table and column names (and require a
HC>org.exolab.castor.persist.spi.PersistenceFactory in the constructor)
HC>7. Extended FieldMolder's constructor to provide the addicional parameter
HC>(and require it itself)
HC>8. Extended ClassMolder's constructor to provide the addicional parameter
HC>
HC>Build and run everything, start the sample application and whoa - success.
Hiran,
I have no problem committing your changes. However, before I accept
anything, I'm curious to know if you've got another database engine
available against which you can exeute the CTF-JDO suite of regression
test cases. See the following for more information:
http://www.castor.org/test-framework.html#Executing-the-Castor-JDO-Test-Cases
This will verify that nothing else has been broken by your changes. If
there is breakage, then you can fix it before sending me your changes.
Also, instead of providing me the files that you changed, please create
contextual diffs (diff -u) of the changed files. From within the castor
dir, execute a cvs diff against your working dir and pipe the results
to a file like so:
cvs diff -u > Tamino-changes.diff
Once you've determined that your changes have not broken anything
else via the regression tests, please file a Bugzilla report
(http://bugzilla.exolab.org/) of type enhancement and attache the diff
file to that report.
Bruce
--
perl -e 'print unpack("u30","<0G)[EMAIL PROTECTED]&5R\"F9E<G)E=\$\!F<FEI+F-O;0\`\`");'
-----------------------------------------------------------
If you wish to unsubscribe from this mailing, send mail to
[EMAIL PROTECTED] with a subject of:
unsubscribe castor-dev
