On Wed, 07 Jan 2004 22:04:42 +0100, Stein M. Hugubakken wrote:
>Hi!
>
>You have logging-statements like this one:
>_log.debug( Messages.format( "jdo.createSql", sql ) );
>
>and in the format-method you have this:
>return format( message, new Object[] { arg1 } );
>
>Problem is that if debug-logging is turned off you still have a overhead.
>
>Debug-statements should be surrounded by a simple if-clause to test if
>debug is enabled:
>if(_log.isDebugEnabled()){
> _log.debug( Messages.format( "jdo.createSql", sql ) );
>}
>
>It is a lot of these logging-statements in Castor and it hurts
>performance I believe (didn't do any performance-tests though).
>
>Comments?
Yes, of course. Mind providing a patch ? I mean, I could do it myself, but I am at the
moment looking at a potential problem with the performance cache
which is quite hard to trace and debug. Your work would really be appreciated.
Werner
>
>Stein
>
>-----------------------------------------------------------
>If you wish to unsubscribe from this mailing, send mail to
>[EMAIL PROTECTED] with a subject of:
> unsubscribe castor-dev
>
-----------------------------------------------------------
If you wish to unsubscribe from this mailing, send mail to
[EMAIL PROTECTED] with a subject of:
unsubscribe castor-dev
