What are the chances of my patch getting into the next release?

http://bugzilla.exolab.org/show_bug.cgi?id=1868

I totally understand the static unmarshal() methods are there for
convenience, which is probably why the third party client I'm using is
using them :)  I imagine other people are also using it out of
convienance.

I test the patch and it does make it easier for someone to set -D and
disable StrictElements. I can think of several reasons why the feature
is useful.

1. if someone needs to debug an issue in production (which is aweful
to do), they can simply set -D and see if it fixes the problem. If it
does, the developer knows the problem is extra elements.

2. it allows users exclude the -D property in development and staging,
but turn StrictElements off for production without having to change
the properties file. Although one could change their deployment so it
extracts the castor jar, modifies the properties file and re-jars it.

3. for projects with complex deployment process on an EJB server, not
having to extract and modify a jar is nice. I guess one could have 1
jar for dev and staging and a second for production. I'm not sure I
like the idea of having two jar files.

obviously, I can make my own build, but I'm hoping others find the
enhancement useful enough to include. thanks

peter



On Wed, 02 Feb 2005 19:35:18 -0600, Keith Visco <[EMAIL PROTECTED]> wrote:
> 
> Peter,
> 
> The static unmarshal() methods are simply for convenience.
> 
> You can easily construct an Unmarshaller, configure it, and invoke it as
> such:
> 
> Unmarshaller unm = new Umarshaller(MyClass.class);
> unm.setIgnoreExtraElements(true);
> unm.unmarshal(myReader);
> 
> --Keith
> 
> Peter Lin wrote:
> > has anyone given thought to making strictelement configurable through
> > system properties? The reason I ask is, for production I would like
> > the ability to turn off strictelements so that in the event a third
> > party changes the schema, the server doesn't just get errors.
> >
> > I was looking over UnmarshalHanlder and the generated java classes are 
> > using:
> >
> > public static Object unmarshal(Class c, Reader r)
> >
> > I was thinking of enhancing the method to check for system properties.
> > this way, I can set the system property in production so it's not
> > strict. But for development I can set it to strict and catch
> > errors/changes in the schema.
> >
> > peter lin
> >
> >
> >
> > -----------------------------------------------------------
> > If you wish to unsubscribe from this mailing, send mail to
> > [EMAIL PROTECTED] with a subject of:
> >         unsubscribe castor-dev
> >
> >
> 
> -----------------------------------------------------------
> If you wish to unsubscribe from this mailing, send mail to
> [EMAIL PROTECTED] with a subject of:
>         unsubscribe castor-dev
>



----------------------------------------------------------- 
If you wish to unsubscribe from this mailing, send mail to
[EMAIL PROTECTED] with a subject of:
        unsubscribe castor-dev

Reply via email to