On Fri, Feb 06, 2009 at 03:16:14PM +0000, Tomas Doran wrote: > > On 6 Feb 2009, at 14:46, Bill Moseley wrote: >> Nobody responded to the main point of this email -- if Catalyst should >> handle encoding in core instead of with a plugin. Nobody has an >> opinion about that? Or is was it just ignored -- which is often how >> people handle character encoding in applications. ;) > > Does it make a difference if its in core or in a plugin? > > In your original email you said that the existing plugins don't do it > right.. Which is quite possibly fair criticism, however I don't see how > moving the functionality into core would help the code be more correct.. > Saying 'Plugin X is broken', 'Lets move Plugin X into core' doesn't sound > very convincing from where I'm sat. :_)
Two different issues, although I would assume if you moved it into core there would be more careful consideration and discussion about how to do it. Which is why I posted -- for a discussion. The question is should encoding be a core function. A plugin works, but not everyone uses it. My argument for doing it in core is that inside Perl is character data so therefore it must be decoded at some point, and it's Catalyst (and the engines) that load the parameters. And if it's character data on the inside it has to be encoded when writing. > Code speaks louder than words, so if you'd like to provide some failing > tests for what you think encoding _should_ be doing, that'd probably be a > better basis for further discussion. Sure. IIRC, I think there's already been some patches and code posted so maybe I can dig that up again off the archives. But, sounds like it's not that important of an issue. -- Bill Moseley mose...@hank.org Sent from my iMutt _______________________________________________ List: Catalyst@lists.scsys.co.uk Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/ Dev site: http://dev.catalyst.perl.org/