On Thu, May 07, 2009 at 02:45:09PM +0100, Tomas Doran wrote: > Chisel Wright wrote: >> I've attached three patches: > > Nice work :) > > For future, patches are possibly best from the top of the distribution, > so that you can just apply them from there without having to work out > where to cd into (for your patches, I had to cd lib, then patch, then cd > ../t, then patch). No big deal however :)
Most odd; I'm pretty sure I was at the top of the dist when I patched: diff -Naur t-orig/lib/TestApp/Component/HTML/Template.pm t/lib/TestApp/Component/HTML/Template.pm --- t-orig/lib/TestApp/Component/HTML/Template.pm 2009-05-06 18:28:43.000000000 +0100 +++ t/lib/TestApp/Component/HTML/Template.pm 2009-05-06 18:35:26.000000000 +0100 > You should just be able to remove the accessor module from the > inheritance here. > > A lot of your changes change NEXT::foo => next::method. Do you really > mean that, or do you mean maybe::next::method? (especially the one where > you say if $self->next::can; > > Your patch also uses Class::C3, rather than MRO::Compat, so people on > perl 5.10 will load Class::C3 (which is not needed) - can you use > MRO::Compat instead? Also, can you add the new dependency to Makefile.PL OK, I'll resubmit tonight/tomorrow. To be honest, I wasn't really sure what I was doing, but I'd found a solution. Cheers for the feedback. Chiz -- Chisel Wright e: chi...@herlpacker.co.uk w: http://www.herlpacker.co.uk/ 'Everyone say chiz!' Otto commanded - Monstrous Regiment _______________________________________________ List: Catalyst@lists.scsys.co.uk Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/ Dev site: http://dev.catalyst.perl.org/