>-----Original Message----- >From: Tomas Doran [mailto:bobtf...@bobtfish.net] >Sent: 16 November 2010 15:41 >To: The elegant MVC web framework >Cc: Anthony Gladdish >Subject: Re: [Catalyst] Catalyst-Authentication-Store-DBIx-Class-User v0.1400 >- patch > > >On 16 Nov 2010, at 15:28, Anthony Gladdish wrote: >> The from_session() method has a call to load() with no $c param. It >> did previously, and this change is breaking my own authentication >> tests. >> Catalyst-Authentication-Store-DBIx-Class 0.1400 test suite passes on >> my attached patch, and my own authentication tests are now passing. >> >> Is there any reason why $c has been ommited here? > >No, it's a bug. > >> Can this patch be merged in please? > >Can you extract a test from your tests and add it to the patch? > >That'll stop the issue ever re-occurring..
Failing test case and it's patch attached. Thanks, Anthony
Cat-Auth-Store-DBIC-0.1400.patch
Description: Cat-Auth-Store-DBIC-0.1400.patch
_______________________________________________ List: Catalyst@lists.scsys.co.uk Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/ Dev site: http://dev.catalyst.perl.org/