Thanks Lukas,
I really appreciate your input and guidance, nice to know I'm thinking along
the right lines, even if bending the rules and re-inventing the wheel in places.
Another thing I found with the built in ORM/DBIC (though correct me if I'm
wrong), is it doesn't work with T-SQL Stored Procedures, which is where I am
heading with a lot of my SQL functionality.
Let SQL do the work, and simply manipulate the returned recordset.
So I have in my underlying SQL helper class....
# Stored Procedure SQL
sub spSQL {
#_0 = Self
#_1 = Stored Procedure with params!
# Declare Local Vars
my ($self,$sp) = @_;
# Connect
my $dbh = $self->dbh;
# Set Long Read (required for DBI & ODBC!)
$dbh->{LongReadLen} = 99999;
# Run SQL Command
my $sth = $dbh->prepare("EXEC $sp") || die("Error in spSQL
($self->{server}): $sp");
$sth->execute();
# Loop SQL Record Set
while (my $ref = $sth->fetchrow_hashref()) {
# Build Array of Hashes with SQL Data
$rs[@rs] = \%$ref;
}
# Return record set
return @rs;
}
Dunno, how do you execute SQL stored procedures using the inbuilt ORM/CRUD via
DBIC ?
Craig.
-----Original Message-----
From: Lukas Thiemeier [mailto:spamcatc...@thiemeier.net]
Sent: 30 October 2012 12:52
To: catalyst@lists.scsys.co.uk
Subject: Re: [Catalyst] Why is $c undefined?
Hi Craig,
You don't understand why "$c->model('Model1')" retrieves and data, because it
doesn't retrieve any data.
Database-code in the controller should be avoided, and instead be implemented
in the model.
My code just passes a reference to "Model2" to "Model1", so "Model1" can access
data from "Model2".
Within "Model1", you can use prepare, execute, fetch et cetera on "Model1" and
"Model2", to fetch the data for your calculations.
Nevertheless, i think that your idea to create a extra model, which has access
to both underlying databases, is a better choice.
Lukas
On 10/30/2012 01:16 PM, Craig Chant wrote:
> Thanks Lukas,
>
> Chained method calls is not my strong point in Perl, they seem easier to read
> in other languages with bracketed encapsulation and the dot notation.
>
> Your helper method is interesting, though I don't understand how
> $c->model("Model1"); retrieves any SQL data, like I said wrapping my head
> around this is a bit of an uphill struggle currently.
>
> Regards,
>
> Craig.
>
>
> -----Original Message-----
> From: Lukas Thiemeier [mailto:spamcatc...@thiemeier.net]
> Sent: 30 October 2012 11:28
> To: The elegant MVC web framework
> Subject: Re: [Catalyst] Why is $c undefined?
>
> Hi Craig,
>
> On 10/30/2012 12:09 PM, Craig Chant wrote:
>> Thanks Ian,
>>
>> The hierarchy is something that I am finding mind-blowing at the moment,
>> "$self->jqgrid->render($self," , you are calling methods jqgrid->render on
>> $self, passing in $self, I'm sure it makes sense to you :-)
>>
>
> No, he is calling "render" on whatever is returned by $self->jqgrid.
> Thats why $self has to be passed to "render". The code above is equivalent to:
>
> my $jqgrid = $self->jqgrid;
> $jqgrid->render($self, ...);
>
>
>> One thing I would like clarification with if possible.
>>
>> Where do I put code that requires the use of more than one model?
>>
>> Do I create a separate model that acts as an interface between the other
>> models?
>
> Thats one possibility. Another possibility would be to create a helper method
> in Model1, which expects Model2 as a parameter.
>
> Model1.pm:
>
> sub calculate_sth_with_model2{
> my ($self, $model2) = @_;
> do_crazy_calculations();
> }
>
> And in your Controller:
>
> sub calculate :Local :Args(0) {
> my ($self, $c) = @_;
>
> my $m1 = $c->model("Model1");
> my $m2 = $c->model("Model2");
>
> $m1->calculate_sth_with_model2($m2);
>
> }
>
>>
>> You see I have two SQL servers in opposite ends of the country and so I have
>> a model built on Model::DBI that can access one server and another Model
>> that can access the other, but I have functionality that needs data from
>> both , do some calculations and output accordingly.
>>
>> I assume this does not go in the controller, but I create an interface model
>> with the required methods and functionality that the controller uses?
>>
>> Regards,
>>
>> Craig.
>>
>> -----Original Message-----
>> From: Ian Docherty [mailto:catal...@iandocherty.com]
>> Sent: 30 October 2012 07:22
>> To: The elegant MVC web framework
>> Subject: Re: [Catalyst] Why is $c undefined?
>>
>> On 29 October 2012 21:01, Craig Chant <cr...@homeloanpartnership.com> wrote:
>> ...
>>>
>>> I have read and seen frameworks such as Mojolicious encourage a shrinkage
>>> of the Model and move alot of functionality to the Controller, so there is
>>> a paradigm which seems to imply it is ok to do more stuff in the
>>> Controller, but I am leaning towards having the main code in the Model and
>>> then bolting it together via the Controller.
>>>
>> I can understand why you get this impression, I think a lot of people end up
>> putting code in the Controller when they first start using MVC (I did so
>> myself in the past).
>>
>> The Model should be external to your Catalyst app (or whatever framework you
>> use) so that you can use it in things like cron jobs. It also makes testing
>> easier if your Model is separate from your Catalyst app. Look at using
>> something like Catalyst::Model::Adaptor as a thin shell to add your external
>> Model into Catalyst.
>>
>> I am moving more and more into making my Controllers as thin as
>> possible. Logic that I might have previously put into the Controller,
>> I either put into the Model or I create helper functions. Here is an
>> example of a Controller (from Mojolicious as it happens but that is
>> not important)
>>
>> sub user_list {
>> my ($self) = @_;
>>
>> $self->jqgrid->render($self, {
>> rs => $self->schema->resultset('User')->search_rs,
>> filters => {},
>> rows => [qw(id name)],
>> });
>> }
>>
>> It's not important to know what is going on here, but this Controller gets a
>> list of all users, formats the data for use in the jQuery jqGrid allows for
>> sorting and filtering and outputs the data in JSON format. The point being,
>> the controller code is kept simple and 'thin'
>> and yet it does a lot of work behind the scenes.
>>
>> _______________________________________________
>> List: Catalyst@lists.scsys.co.uk
>> Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
>> Searchable archive:
>> http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
>> Dev site: http://dev.catalyst.perl.org/ This Email and any
>> attachments contain confidential information and is intended solely
>> for the individual to whom it is addressed. If this Email has been
>> misdirected, please notify the author as soon as possible. If you are
>> not the intended recipient you must not disclose, distribute, copy,
>> print or rely on any of the information contained, and all copies
>> must be deleted immediately. Whilst we take reasonable steps to try
>> to identify any software viruses, any attachments to this e-mail may
>> nevertheless contain viruses, which our anti-virus software has
>> failed to identify. You should therefore carry out your own
>> anti-virus checks before opening any documents. HomeLoan Partnership
>> will not accept any liability for damage caused by computer viruses
>> emanating from any attachment or other document supplied with this
>> e-mail. HomeLoan Partnership reserves the right to monitor and
>> archive all e-mail communications through its network. No
>> representative or employee of HomeLoan Partn
> ership ha
> s the authority to enter into any contract on behalf of HomeLoan Partnership
> by email. HomeLoan Partnership is a trading name of H L Partnership Limited,
> registered in England and Wales with Registration Number 5011722. Registered
> office: 26-34 Old Street, London, EC1V 9QQ. H L Partnership Limited is
> authorised and regulated by the Financial Services Authority.
>>
>> _______________________________________________
>> List: Catalyst@lists.scsys.co.uk
>> Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
>> Searchable archive:
>> http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
>> Dev site: http://dev.catalyst.perl.org/
> u
>
> _______________________________________________
> List: Catalyst@lists.scsys.co.uk
> Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
> Searchable archive:
> http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
> Dev site: http://dev.catalyst.perl.org/ This Email and any attachments
> contain confidential information and is intended solely for the
> individual to whom it is addressed. If this Email has been
> misdirected, please notify the author as soon as possible. If you are
> not the intended recipient you must not disclose, distribute, copy,
> print or rely on any of the information contained, and all copies must
> be deleted immediately. Whilst we take reasonable steps to try to
> identify any software viruses, any attachments to this e-mail may
> nevertheless contain viruses, which our anti-virus software has failed
> to identify. You should therefore carry out your own anti-virus checks
> before opening any documents. HomeLoan Partnership will not accept any
> liability for damage caused by computer viruses emanating from any
> attachment or other document supplied with this e-mail. HomeLoan
> Partnership reserves the right to monitor and archive all e-mail
> communications through its network. No representative or employee of
> HomeLoan Partn
ership ha
s the authority to enter into any contract on behalf of HomeLoan Partnership by
email. HomeLoan Partnership is a trading name of H L Partnership Limited,
registered in England and Wales with Registration Number 5011722. Registered
office: 26-34 Old Street, London, EC1V 9QQ. H L Partnership Limited is
authorised and regulated by the Financial Services Authority.
>
> _______________________________________________
> List: Catalyst@lists.scsys.co.uk
> Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
> Searchable archive:
> http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
> Dev site: http://dev.catalyst.perl.org/
_______________________________________________
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/
This Email and any attachments contain confidential information and is intended
solely for the individual to whom it is addressed. If this Email has been
misdirected, please notify the author as soon as possible. If you are not the
intended recipient you must not disclose, distribute, copy, print or rely on
any of the information contained, and all copies must be deleted immediately.
Whilst we take reasonable steps to try to identify any software viruses, any
attachments to this e-mail may nevertheless contain viruses, which our
anti-virus software has failed to identify. You should therefore carry out your
own anti-virus checks before opening any documents. HomeLoan Partnership will
not accept any liability for damage caused by computer viruses emanating from
any attachment or other document supplied with this e-mail. HomeLoan
Partnership reserves the right to monitor and archive all e-mail communications
through its network. No representative or employee of HomeLoan Partnership has
the authority to enter into any contract on behalf of HomeLoan Partnership by
email. HomeLoan Partnership is a trading name of H L Partnership Limited,
registered in England and Wales with Registration Number 5011722. Registered
office: 26-34 Old Street, London, EC1V 9QQ. H L Partnership Limited is
authorised and regulated by the Financial Services Authority.
_______________________________________________
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/
