Hi Arieh, Thank you for the feedback, this is indeed a scenario the validator did not handle! The validator was only checking for a set group of exceptions - and the pre-processor exceptions were not in this group.
I have made a couple of modifications to the validator to both include these exceptions, and also to prevent it from crashing in a similar situation. Craig -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Arieh Schneier Sent: Tuesday, 14 April 2009 5:04 p.m. To: ccnet-user Subject: [ccnet-user] Re: Validation Program PS Note, I don't have the server installed on my PC, I only have CCTray installed (and now the validator). Arieh On Apr 14, 3:01 pm, Arieh Schneier <[email protected]> wrote: > I tried it out, it worked fine on my current config (which was a > correct working config), so I wanted to see what would happen when it > was wrong. I went into 1 of the included files and change one of the > lines to be incorrect and the program crashed (I was able to hit > Continue but then the file just didn't finish loading)... > > Working line: > <cb:LevelExport Level="levelname"/> > Changed line causeing crash (note an extra 's'): > <cb:LevelExports Level="levelname"/> > > Top of the Exception stack: > ThoughtWorks.CruiseControl.Core.Config.Preprocessor.EvaluationException: > Reference to unknown symbol LevelExports > at > ThoughtWorks.CruiseControl.Core.Config.Preprocessor.Utils.ThrowException > (ExceptionFactory factory, String fmt, Object[] args) > at > ThoughtWorks.CruiseControl.Core.Config.Preprocessor.ConfigPreprocessorEnviro nment._GetConstantDef > (String name) > at > ThoughtWorks.CruiseControl.Core.Config.Preprocessor.ConfigPreprocessorEnviro nment.eval_constant > (String name) > at > ThoughtWorks.CruiseControl.Core.Config.Preprocessor.ConfigPreprocessor.PrePr ocess > (XmlReader input, XmlWriter output, PreprocessorUrlResolver resolver, > Uri input_uri) > at > ThoughtWorks.CruiseControl.Core.Config.DefaultConfigurationFileLoader.Create XmlValidatingLoader > (FileInfo configFile) > at > ThoughtWorks.CruiseControl.Core.Config.DefaultConfigurationFileLoader.Attemp tLoadConfiguration > (FileInfo configFile) > at > ThoughtWorks.CruiseControl.Core.Config.DefaultConfigurationFileLoader.Load > (FileInfo configFile) > at Validator.MainForm.StartConfigurationLoad() > > On Apr 12, 8:53 pm, "Craig & Sammi Sutherland" > > <[email protected]> wrote: > > Hi Ron, > > > I'm glad you like the new validator tool. > > > It was supposed to be included in the installer for 1.4.3, but there was a > > glitch in the build which meant it didn't get included. This has now been > > fixed, so the installer for versions 1.4.4 or later include the tool by > > default. > > > Additionally to make it easier to get hold of the validator, it now has its > > own installer. This can be downloaded from CCNetLive > > (http://ccnetlive.thoughtworks.com/CCNet-builds/1.4.4/). This duplicates > > most of the binaries from the main install, so it's only needed for machines > > that don't have CruiseControl.NET installed on them. > > > We're also making small improvements to the tool to provide more validation, > > so feel free to send any feedback on how to improve it. > > > Craig > > > -----Original Message----- > > From: [email protected] [mailto:[email protected]] On > > > Behalf Of rifferte > > Sent: Friday, 10 April 2009 7:54 a.m. > > To: ccnet-user > > Subject: [ccnet-user] Validation Program > > > All, > > > I just wanted to comment and thank the CC Developers on the > > ccnet.config validation program including in 1.4.3. This has easily > > given me a few hours of my life back. > > > THANK YOU! > > > If you are not already using it - you should download the source, > > compile and put it in your tool belt. It is very handy! > > > - Ron
