Hi

yup, that's  a logic error I made there :-(

But the main idea is that it is easy to create your own trigger or so,
makes it a lot easier to finetune to ones need.


About the commenting, this is strange because I have allow any user to
comment,
the blog does not require registration or an open id.

I'll need to check this.

with kind regards
Ruben Willems

On Tue, Apr 5, 2011 at 11:42 AM, Daniel Rose <[email protected]> wrote:

> Thanks a lot!
> I'll have to test if it works as planned.
>
> Since I can't comment on your blog post I'll write here:
>
> In SubProjectsAreChanged(), you immediately return true if a
> subproject has been built in the meantime. However, a not-yet-checked
> subproject may be in a failed state. Locally I changed it to save this
> to a temporary variable and return it at the end:
>
> var anySubProjectChanged = false;
> foreach (var subprojectName in this.SubProjectsToWatch)
> {
> ...
>    if (lastTimeBuildInIntegration < lastbuildinfo.LastBuildDate)
>    {
>        // A change has occured. Store this info for later.
>        anySubProjectChanged = true;
>    }
> ...
> }
>
> return anySubProjectChanged;

Reply via email to