On Fri, 10 Aug 2012, [email protected] wrote:
> Hi folks,
>
> I've taken into account peoples comments with regard to patch format and not
> including changes that are just reformatting. The attached patch is solely for
> imake, adding function prototypes where they are missing, limiting linkage to
> static scope wherever possible and removing a bunch of GCC warnings.
>
> Regards,
>
> Chris
>
I have applied this, though with reservations... While I agree that
making functions static has a useful purpose, I see no real value in
this case, since imake isn't linked with anything where it would
matter.
I do like the K&R->ANSI conversion and other fix ups, but I would
prefer that no more 'static-ification' patches be submitted unless
they are solving a real problem.
--
Jon Trulson
"If the Martian rope-a-dope don't get him, he'll get himself, he'll
come in too fast and punch himself out."
- one of my brothers, referring to the Curiosity landing.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
cdesktopenv-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
