tzsetwall() is a non-standard extension (BSD origin, present in Solaris, some BSDs). It's something that should probably be #ifdef'd because tzset() is POSIX. tzset() uses the $TZ environment variable and tzsetwall() uses /etc/localtime and ignores $TZ.
I run CDE on NetBSD also. So there is at least one more OS to test for if it matters in your code. On Tue, May 19, 2026 at 10:34 AM Brian Cole <[email protected]> wrote: > Couple thoughts: > > 1: I'm not qualified to comment on whether replacing tzsetwall with tzset > is a good idea, but that doesn't seem related to adding Chinese language > support; shouldn't that be a second patch? > > 2: There's a `if SOLARIS` conditional - if you only tested on Debian, do > we have any reason to think that works? (Shouldn't be too hard to test on > illumos, at least?) > > Thanks, > Brian > > On Tue, May 19, 2026, at 9:39 AM, Leo wrote: > > I have added full Chinese language support, with the detailed changes as > follows: > > I added build flags for Simplified Chinese and Traditional Chinese in the > configure.ac script, namely --enable-chinese and --enable-chinese-tw. > Both options are disabled by default, consistent with other language > configurations. Corresponding conditional compilation logic has been > implemented, and relevant localisation directory build entries have been > supplemented in the file build list. > > I revised the time handling source file timeops.c, replacing the > SVR4-specific tzsetwall function with the cross-platform standard tzset > function, > which fixes compilation and runtime compatibility issues on modern Linux > and BSD systems. > > I adjusted the main build configuration Makefile.am under the localized > directory, > adding conditional compilation branches for Chinese languages. The > corresponding Chinese localisation subdirectories will be compiled > automatically once the relevant build options are enabled. > > I created new build template files Chinese.am and Chinese_TW.am in the > templates folder, with separate environment variable rules tailored for > Solaris and general Unix-like operating systems. > > I built the complete directory structure for zh_CN.UTF-8 Simplified > Chinese localisation, including all subdirectories and corresponding build > configurations, and initialised basic message catalogue files. > > I optimised the existing zh_TW.UTF-8 Traditional Chinese localisation > configurations: removed obsolete comments and outdated font settings, > eliminated redundant whitespace in message texts, and fixed formatting > errors at the end of version comment lines. > > Standardised Makefile.am build scripts have been written for all newly > added Chinese localisation directories, which inherit universal template > rules and automatically clean up temporary build files. > > All modified CDE source code compiles successfully on Debian 13. > > Required dependencies: > > sudo apt-get -y install autoconf automake libtool git build-essential g++ > libxt-dev libxmu-dev libxft-dev libxinerama-dev libxpm-dev libpam0g-dev > libmotif-dev libssl-dev libxaw7-dev libx11-dev libxss-dev libtirpc-dev > libjpeg-dev libfreetype-dev libutempter-dev libxrender-dev tcl-dev ksh m4 > ncompress xfonts-100dpi xfonts-75dpi xfonts-100dpi-transcoded > xfonts-75dpi-transcoded rpcbind bison patch xbitmaps x11proto-fonts-dev > flex opensp x11-xserver-utils liblmdb-dev > > > > Please merge these commits at your earliest convenience. This improvement > is greatly meaningful for Chinese users who are fond of retro computing > environments. Thank you very much! > Leo Lee > > _______________________________________________ > cdesktopenv-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel > > > *Attachments:* > > - cde-add-chinese.patch > > > _______________________________________________ > cdesktopenv-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel >
_______________________________________________ cdesktopenv-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel
