On Aug 24, 2008, at 12:14 PM, Bala B K wrote:
> Hello,
>
> I was looking at the IRingSet interface and was wondering why
> getRings(IAtom) and getRings(IBond) return different types.
> getRings(IAtom) returns an IRingSet of all the rings that the atom
> belongs to but getRings(IBond) returns a List of all rings that the
> bond belongs to, instead of returning an IRingSet. It would be nice to
> have the same return type for both functions.
Good point - I'd vote for changing the type, consistently, to
IRingSet. Can you file a bug report
On a related, given that certain methods return IRingSet and
List<IRing> it seems that the semantics of IRingSet are very similar
to a List, except that it has some extra methods.
So why not simply make IRingSet implement List (or a subclass of
ArrayList)? Of course this implies that IAtomContainerSet (the parent
class) should also implement List. It seems to me that a lot of the
code reagrding storage, multipliers etc, could be removed and handled
by the core Java classes/interfaces.
In fact, for IAtomContainerSet, what is the special functionality
that is not provided by List? I see no difference between the methods
of IAtomContainerSet and List (aaprt form the names). Is it just a
'syntactic sugar' class?
-------------------------------------------------------------------
Rajarshi Guha <[EMAIL PROTECTED]>
GPG Fingerprint: D070 5427 CC5B 7938 929C DD13 66A1 922C 51E7 9E84
-------------------------------------------------------------------
So the Zen master asked the hot-dog vendor,
"Can you make me one with everything?"
- TauZero on Slashdot
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Cdk-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/cdk-user
