Hi Egon, Rajarshi,

Thanks for the explanation, that clears it up.

The readerfactory works as expected, but the code fragment on
Rajarshi's blog camouflaged this by saying :

IChemObjectReader reader = readerFactory.createReader(new FileReader(input));

I.E. assigning the returned ISimple..reader to the parent interface,
losing the read method.
Simply changing this to:

ISimpleChemObjectReader reader = readerFactory.createReader(new
FileReader(input));

fixes everything. I feel a little dumb now.

I've written a few lines of javadoc and will send the patch to the tracker now.

Cheers!
Jules

On 22 July 2010 15:36, Egon Willighagen <[email protected]> wrote:
> On Thu, Jul 22, 2010 at 3:29 PM, Rajarshi Guha <[email protected]> 
> wrote:
>>> The reader factory should actually indeed return
>>> ISimpleChemObjectReader... OK, that would be a second bug.
>>
>> It does in master
>
> Ah. Then perhaps it was decided to not put that change in 1.2.x too,
> because it would change the API after 1.2.0...
>
> Will still need to update the JavaDoc to explain...
>
> Egon
>
> --
> Post-doc @ Uppsala University
> Proteochemometrics / Bioclipse Group of Prof. Jarl Wikberg
> Homepage: http://egonw.github.com/
> Blog: http://chem-bla-ics.blogspot.com/
> PubList: http://www.citeulike.org/user/egonw/tag/papers
>

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
Cdk-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/cdk-user

Reply via email to