On Thu, Sep 16, 2010 at 8:28 AM, Egon Willighagen <[email protected]> wrote: > On Thu, Sep 16, 2010 at 8:24 AM, Thomas G. Kristensen <[email protected]> wrote: >> On Wed, Sep 15, 2010 at 12:43 PM, Egon Willighagen >> <[email protected]> wrote: >>> You can file a feature request... best to add an example file that we >>> can use as test data, so LGPL licensed... a small demo file will do, >>> so that we can write a unit test. >> Hmmm, seems like a lot of work for such a simple feature. > It's not needed for adding the feature; it's for making sure the > feature works in 5 years too. Fair enough, better build solid software :) I did the silly thing and just implemented the feature and recompiled the source. I have not written any tests, but if you're interested in the updated version I've attached it.
>> Do you mean >> that the molecular file is supposed to be released under LGPL? I don't >> think anybody has ever done that. > All the test data in src/test/data is distributed as LGPL... Okay. I'm not sure what my datas license is so I haven't added it. Once again, thanks for all your help. I'm happy that the community supports solid software and I understand if my altered Mol2Reader wont be added to the current version until proper tests are set up. Thomas
Mol2Reader.java
Description: Binary data
------------------------------------------------------------------------------ Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________ Cdk-user mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/cdk-user
