Hi Egon, I also support Nina's idea: - CDKException should be a root of all other CDK-specific exceptions. - The use of self-explanatory exceptions like NoSuchAtomTypeException is very welcomed, but in case there is no proper exception, throwing CDKException+message is fine. - Using IllegalArgumentException in proper context is absolutely fine. JavaDoc should mention that this exception is thrown when passed arguments do not meet certain constraints.
On 06.07.2011 12:35, Nina Jeliazkova wrote: > Hello Egon, > > 1) and 2) are not mutually exclusive. > > My preference would be for 1) CDKException but combined with 2) > CDKException subclasses , e.g. NoSuchAtomTypeException should extend > CDKException class. This will leave a freedom for the code to catch > the top level or the more specific exception. > > Dropping CDK specific exceptions and sticking to 3) only , will likely > complicate troubleshooting in more complex environment, as a generic > Java exception might come from elsewhere, and will be harder work to > blame the CDK code in case of failure ;) > > Regards, > Nina -- With best regards, Dmitry ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Cdk-user mailing list Cdk-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/cdk-user
