Kevin O'Connor escreveu:
> Attached is the file. It is not in the form of a patch, because I
> don't know where one would place it in the heirarchy.
Humm, put it in w32api/include for now. There is already precedent in
w32api/include/rapi.h.
It just needs a little bit of cleanup to be perfect, because
w32api/include headers follows a specific style.
- The header guards should only have one underscore (_PKFUNCS_H).
- There should be a:
#if __GNUC__ >=3
#pragma GCC system_header
#endif
... at the top of header.
- The function parameters should have no variable names. eg:
-BOOL UnlockPages(LPVOID lpvAddress, DWORD cbSize);
+BOOL UnlockPages(LPVOID, DWORD);
- Put a comment explaining that this file is not strict win32 api.
w32api/include/rapi.h has this:
/* rapi.h - main header file for the RAPI API
NOTE: This strictly does not belong in the Win32 API since it's
really part of Platform SDK.
*/
Something similar would be fine.
- Don't use c++ style comments (//).
Cheers,
Pedro Alves
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Cegcc-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/cegcc-devel
