Am 21.11.2012 09:26, schrieb Stefan Hajnoczi:
On Wed, Nov 21, 2012 at 08:47:16AM +0100, Stefan Priebe - Profihost AG wrote:
Am 21.11.2012 07:41, schrieb Stefan Hajnoczi:
We're going in circles here. I know the types are wrong in the code and
your patch fixes it, that's why I said it looks good in my first reply.
Sorry not so familiar with processes like these.
QEMU is currently in hard freeze and only critical patches should go in.
Providing steps to reproduce the bug helps me decide that this patch
should still be merged for QEMU 1.3-rc1.
Anyway, the patch is straightforward, I have applied it to my block tree
and it will be in QEMU 1.3-rc1:
https://github.com/stefanha/qemu/commits/block
Thanks!
The steps to reproduce are:
mkfs.xfs -f a whole device bigger than int in bytes. mkfs.xfs sends a
discard. Important is that you use scsi-hd and set
discard_granularity=512. Otherwise rbd disabled discard support.
Might you have a look at my other rbd fix too? It fixes a race between
task cancellation and writes. The same race was fixed in iscsi this summer.
Greets,
Stefan
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
