Hi Greg, Sure. I'm interested in all feedback you come up with, but for starters, it would be helpful to have feedback on
1. the Messenger reorg in general, and perhaps specifically how to think about the throttle ideas that I shoved into SimplePolicyMessenger 2. about the completion mechanisms--with the addition of claim_data, this is provisionally complete 3. about DispatchStrategy and non-prio queueing, and how the way we're doing things relates to your parallel work with SimpleMessenger Thanks, Matt ----- "Gregory Farnum" <g...@inktank.com> wrote: > Awesome! I'll try and take a preliminary look at this in the next day > or two. What kind of feedback are you interested in right now? > -Greg > Software Engineer #42 @ http://inktank.com | http://ceph.com > > On Tue, Apr 22, 2014 at 12:44 PM, Matt W. Benjamin <m...@linuxbox.com> > wrote: > > Hi, > > > > We've completed a trial merge of our current XioMessenger branches > to Ceph > > upstream master. The resulting branch is on our public Ceph > development > > repo, on banch xio-rados-firefly: > > > > > https://github.com/linuxbox2/linuxbox-ceph/commits/xio-rados-firefly > > > > This branch isn't fully vetted. We haven't re-run librados tests on > it, and > > there may be issues. In addition, the core XioMessenger code on > this branch > > has at least one open bug (a race condition) that appeared after we > switched > > to Accelio one-way messages (which streamline the workflow, and are > faster than > > the original request-response code). We'll send an update on this > to the > > list as soon as we can (later this week). > > > > There is also ongoing merge work (making XioMessenger work with the > rest of > > Ceph), and open items (e.g., XioMessenger doesn't implement CephX). > > > > What I think is good about this branch is it has all the commits > broken out, > > starting with general changes to the Messenger class family, for > review. > > > > Thanks and regards, > > > > Matt > > > > -- > > Matt Benjamin > > The Linux Box > > 206 South Fifth Ave. Suite 150 > > Ann Arbor, MI 48104 > > > > http://linuxbox.com > > > > tel. 734-761-4689 > > fax. 734-769-8938 > > cel. 734-216-5309 -- Matt Benjamin The Linux Box 206 South Fifth Ave. Suite 150 Ann Arbor, MI 48104 http://linuxbox.com tel. 734-761-4689 fax. 734-769-8938 cel. 734-216-5309 -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html