On 06/25/2014 12:16 PM, Ilya Dryomov wrote: > We should check if request is on the linger request list of any of the > OSDs, not whether request is registered or not. > > Signed-off-by: Ilya Dryomov <ilya.dryo...@inktank.com>
That was a difficult to spot bug. Very good. Reviewed-by: Alex Elder <el...@linaro.org> > --- > net/ceph/osd_client.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c > index 12ec553a7e76..8104db24bc09 100644 > --- a/net/ceph/osd_client.c > +++ b/net/ceph/osd_client.c > @@ -1221,7 +1221,7 @@ static void __unregister_request(struct ceph_osd_client > *osdc, > > list_del_init(&req->r_osd_item); > maybe_move_osd_to_lru(osdc, req->r_osd); > - if (list_empty(&req->r_linger_item)) > + if (list_empty(&req->r_linger_osd_item)) > req->r_osd = NULL; > } > > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
