Hi Frank,

The semantic of osd_snap_trim_sleep was copied from osd_delete_sleep.

The general setting "osd_snap_trim_sleep" is used only to override the
_hdd _hybrid _ssd tuned values.

Here's the code to get the effective sleep value:

if (osd_snap_trim_sleep > 0)
    return osd_snap_trim_sleep;
if (!store_is_rotational && !journal_is_rotational)
    return osd_snap_trim_sleep_ssd
if (store_is_rotational && !journal_is_rotational)
    return osd_snap_trim_sleep_hybrid
return osd_snap_trim_sleep_hdd


Do you think the doc needs to be updated?

Cheers, Dan


On Thu, Feb 24, 2022 at 12:27 PM Frank Schilder <fr...@dtu.dk> wrote:
>
> I seem to have the opposite problem with fs snaptrim progress as others 
> recently. I would like to speed it up. I looked at the docs and find the 
> description of osd_snap_trim_sleep* 
> (https://docs.ceph.com/en/latest/rados/configuration/osd-config-ref/#confval-osd_snap_trim_sleep)
>  counter-intuitive and confusing.
>
> For osd_snap_trim_sleep it says "This option overrides backend specific 
> variants.", which is exactly the opposite of how other options are applied, 
> for example, the osd_memory_target family of options. The usual way is that 
> more specific options (back-end specific) supersede less specific options 
> (general defaults). What is correct? Is the overall default sleep=0 for all 
> types of OSDs, or is it 5s(=osd_snap_trim_sleep_hdd) for HDDs?
>
> If the documentation is wrong, please correct.
>
> Thanks and best regards,
> =================
> Frank Schilder
> AIT Risø Campus
> Bygning 109, rum S14
> _______________________________________________
> ceph-users mailing list -- ceph-users@ceph.io
> To unsubscribe send an email to ceph-users-le...@ceph.io
_______________________________________________
ceph-users mailing list -- ceph-users@ceph.io
To unsubscribe send an email to ceph-users-le...@ceph.io

Reply via email to