Yeah, when I first started in CF, I had to deal with the code of my predecessor, he surrounded very page with a single set of <cfoutput> tags and left justified everything, no indentation at all. It would take me hours just to read it.
I took his name in vain more than a few times.... Scott A. Stewart, Web Application Developer Engineering Consulting Services, Ltd. (ECS) 14026 Thunderbolt Place, Suite 300 Chantilly, VA 20151 Phone: (703) 995-1737 Fax: (703) 834-5527 "Many thousands of years ago, a blue faced Pict stepped on a bloated sheep carcass... and thus the Pipes were born" .... the Scottish Rogues -----Original Message----- From: Rick Root [mailto:[EMAIL PROTECTED] Sent: Friday, July 22, 2005 11:30 am To: CF-Talk Subject: Working with OPC (Other People's Code) Importance: Low <rant> I took over this job from another guy about almost 3 years ago. Many of the things he built I have rewritten. In many cases, I found it easier to rewrite them from scratch than to fix them or enhance them. For example, here is a snippet of his code that exemplifies that type of programming that he did: ------------------------------------------------------------ <CFIF #FindNoCase("http://";, EVENTURL)# OR #FindNoCase("https://";, EVENTURL)#> <CFELSEIF #Trim(EVENTURL)# IS ""> <CFSET EVENTURL = EVENTURL> <CFELSE> <CFSET EVENTURL = "http://"; & EVENTURL> </CFIF> ------------------------------------------------------------ Here is my version, rewritten: ------------------------------------------------------------ <cfif EVENTURL neq "" and reFindNoCase("https?://",EVENTURL) eq 0> <cfset EVENTURL = "http://"; & EVENTURL> </cfif> ------------------------------------------------------------ Life is grand, ain't it? </rant> Rick ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~| Find out how CFTicket can increase your company's customer support efficiency by 100% http://www.houseoffusion.com/banners/view.cfm?bannerid=49 Message: http://www.houseoffusion.com/lists.cfm/link=i:4:212568 Archives: http://www.houseoffusion.com/cf_lists/threads.cfm/4 Subscription: http://www.houseoffusion.com/lists.cfm/link=s:4 Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=89.70.4 Donations & Support: http://www.houseoffusion.com/tiny.cfm/54
