On Oct 20, 2008, at 7:15 AM, Zhongxing Xu wrote: > Do you think it seems more reasonable for VisitCast to specially > handle the case of casting an array type to a pointer? One possible > solution in this case would be to have VisitCast invoke VisitLValue > on its subexpression when performing such a cast. I'm not certain > if this is the right thing to do. > > > After examining the code in CodeGen part of clang, now I think this > approach is also feasible. And it seems more reasonable to do so.
Great. Before doing so, perhaps we should break your current patch into a bunch of smaller ones that implement functionality independent of getting everything right for array types. That way (a) those pieces are easier to review and (b) we don't end up with one colossal patch. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
