On Thu, Oct 30, 2008 at 1:18 PM, Ted Kremenek <[EMAIL PROTECTED]> wrote:

>
> On Oct 29, 2008, at 10:02 PM, Zhongxing Xu wrote:
>
>  +  if (T->isArrayType()) {
>> +    for (unsigned i = 0; i < NumInitElements; ++i) {
>> +      Expr* Init = E->getInit(i);
>> +      NodeSet Tmp;
>> +      Visit(Init, Pred, Tmp);
>>
>
> ....
>
>
>> +
>> +  if (T->isStructureType()) {
>> +    // FIXME: to be implemented.
>> +    MakeNode(Dst, E, Pred, state);
>> +    return;
>> +  }
>> +
>>
>
> Looks great.  Should these two cases be merged?  if (T->isArrayType() ||
> T->isStructureType())?
>

Yes. I'll do it in a later patch. Now I am renaming.
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to