On Tue, Nov 11, 2008 at 8:51 PM, Chris Lattner <[EMAIL PROTECTED]> wrote:
>
> On Nov 11, 2008, at 1:03 PM, Eli Friedman wrote:
>
>> On Tue, Nov 11, 2008 at 10:56 AM, Chris Lattner <[EMAIL PROTECTED]> wrote:
>>>
>>> +    if (CondCI->getZExtValue() == 0)
>>
>> This will break once we add support for 128-bit integers.
>
> No it won't, because this is guaranteed to be an i1.  However, I'll change
> it anyway to clean it up.

No, CondCl is an arbitrary integer.  Note the comment above the
declaration of CondVal: "Evaluate the conditional, then convert it to
bool.  We do this explicitly because we need the unconverted value if
this is a GNU ?: expression with missing middle value."

-Eli
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to