On Nov 20, 2008, at 9:04 AM, Daniel Dunbar wrote: > Hi Fariborz, > > A few comments: > > For readability consider splitting commits which hit several layers > (Parser/Sema/CodeGen) into independent commits. > > On Wed, Nov 19, 2008 at 4:15 PM, Fariborz Jahanian <[EMAIL PROTECTED] > > wrote: >> +DIAG(warn_attribute_weak_on_field, WARNING, >> + "__weak attribute cannot be specified on a field declaration") > > This spelling strikes me as odd, since __weak is just a define. I > presume this matches gcc though?
__weak is just a #define, but objc programmers treat and think of it as a language feature. It would be very confusing to see __attribute__((weak)) in a diagnostic. -Chris _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
