I'd prefer broadcast, it guarantees best solution. - Elena
-----Original Message----- From: Adam Nemet [mailto:[email protected]] Sent: Tuesday, July 29, 2014 19:57 To: Demikhovsky, Elena Cc: [email protected] Subject: Re: [PATCH][AVX512] More intrinsics not requiring new backend support On Jul 29, 2014, at 6:35 AM, Demikhovsky, Elena <[email protected]> wrote: > Hi Adam, > > 1) > set1_pd, set1_ps, set1_epi64, set1_epi32 should be implemented as broadcast. > > 2) > I don't understand in "casts". Hi Elena, I should have mentioned in the log that both set1 and the casts are widened versions of their counterparts in AVX (see avxintrin.h). In particular for set1 and any other op that can be implemented without machine intrinsics, that is usually the preferred way (see r22c5bf6 in clang for an example). This allows them to be recognized and optimized by the machine-independent optimization passes. > 3) > __builtin_ia32_knothi receives unsigned short It should look like > > BUILTIN(__builtin_ia32_knothi, "Us", "") instead of > +BUILTIN(__builtin_ia32_knothi, "ss", "") Good catch, thanks. I will change this to UsUs. Please let me know if you're OK with the patches after this fix and with the additional comment above. Thanks, Adam > > - Elena > > > -----Original Message----- > From: Adam Nemet [mailto:[email protected]] > Sent: Tuesday, July 29, 2014 10:11 > To: Demikhovsky, Elena > Cc: [email protected] > Subject: [PATCH][AVX512] More intrinsics not requiring new backend > support > > Hi Elena, > > Please let me know if these look good to you. > > Thanks, > Adam > > --------------------------------------------------------------------- > Intel Israel (74) Limited > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > --------------------------------------------------------------------- Intel Israel (74) Limited This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
