lgtm if you don't ignore -malign-double. Sorry, I just did a search for unread reviews.
================ Comment at: include/clang/Driver/Options.td:1041 @@ +1040,3 @@ +def malign_jumps_EQ : Joined<["-"], "malign-jumps=">, Group<clang_ignored_m_Group>; +def malign_double : Flag<["-"], "malign-double">, Group<clang_ignored_m_Group>; +def mfancy_math_387 : Flag<["-"], "mfancy-math-387">, Group<clang_ignored_m_Group>; ---------------- -malign-double is an ABI breaking flag, as it affects record layout. We should reject it with prejudice. :) ================ Comment at: include/clang/Driver/Options.td:1628 @@ -1619,2 +1627,3 @@ defm float_store : BooleanFFlag<"float-store">, Group<clang_ignored_gcc_optimization_f_Group>; +defm friend_injection : BooleanFFlag<"friend-injection">, Group<clang_ignored_f_Group>; defm function_attribute_list : BooleanFFlag<"function-attribute-list">, Group<clang_ignored_f_Group>; ---------------- Amusing, we implement this behavior under -fms-compatibility. http://reviews.llvm.org/D4570 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
