Thx, submitted as r214852.
On Mon, Aug 4, 2014 at 6:53 PM, Jacques Pienaar <[email protected]> wrote: > I don't have commit access so I'd need your help. Thanks > > > On Mon, Aug 4, 2014 at 9:50 AM, Manuel Klimek <[email protected]> wrote: > >> Looks good. Do you have commit access or do you need me to commit? >> >> >> On Mon, Aug 4, 2014 at 6:35 PM, Jacques Pienaar <[email protected]> >> wrote: >> >>> Good point :) Added a negative test for matchesWithCuda and >>> notMatchesWithCuda. And will use phab in future. >>> >>> >>> On Mon, Aug 4, 2014 at 4:35 AM, Manuel Klimek <[email protected]> wrote: >>> >>>> On Mon, Aug 4, 2014 at 1:34 PM, Manuel Klimek <[email protected]> >>>> wrote: >>>> >>>>> On Fri, Aug 1, 2014 at 7:43 PM, Jacques Pienaar <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> The patch adds ASTMatchers for matching CUDA declarations. >>>>>> >>>>>> Kindly asking for review. >>>>>> >>>>> >>>>> (just for the future: it'll make it easier for me to review if you run >>>>> it through phab - this change is small enough that it doesn't make a big >>>>> difference though) >>>>> >>>>> Can you please run: >>>>> $ cd tools/clang/docs/tools >>>>> $ python ./dump_ast_matchers.py >>>>> (this will automatically update the documentation) >>>>> >>>> >>>> Also, you might want to add a reverse test (otherwise we have a) code >>>> that's not executed and b) we could implement matchesWithCuda as "return >>>> true" :) >>>> >>>>> >>>>> >>>>>> >>>>>> Jacques >>>>>> >>>>>> -- >>>>>> Jacques Pienaar | Platforms | [email protected] | 765-430-6883 >>>>>> >>>>>> _______________________________________________ >>>>>> cfe-commits mailing list >>>>>> [email protected] >>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >>>>>> >>>>>> >>>>> >>>> >>> >>> >>> -- >>> Jacques Pienaar | Platforms | [email protected] | 765-430-6883 >>> >> >> > > > -- > Jacques Pienaar | Platforms | [email protected] | 765-430-6883 >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
