On 8/29/14, 10:59 AM, Dan Albert wrote:
I'm a little bit worried about the no-threads build bit-rotting (if any of us
forget to wrap something in #ifndef _LIBCPP_HAS_NO_THREADS).
I'm a bit worried about that too, but I am willing to maintain it.
Should we have a buildbot set up to build this configuration?
I would appreciate having one, but I can't host it at the moment.
At some point I would like to host a baremetal buildbot (targeting either QEMU,
a raspberry pi, or some beagleboard), but I'm not quite ready for that... we
need to work out the details of remote testing in lit before that is practical.
Would it be possible to define noop implementations of all the things
you've ifdef'd out so that we don't have to worry about that?
> It's possible that would make things more or a mess, but I'm not sure.
I think that nop-shims have an even higher potential for bit-rot than these
#ifdef's.
I originally attempted writing no-op shims for a few of them, but there were
several where it didn't seem possible, and others where the shims were pretty hairy.
Jon
================
Comment at: src/condition_variable.cpp:19
@@ -14,2 +18,3 @@
+
_LIBCPP_BEGIN_NAMESPACE_STD
----------------
nit
http://reviews.llvm.org/D3969
--
Jon Roelofs
[email protected]
CodeSourcery / Mentor Embedded
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
