If you really think this is the right change, by all means, check it in. I'd 
just be excited if we found a different way to address the problem.

================
Comment at: include/clang/ASTMatchers/Dynamic/VariantValue.h:126
@@ -112,3 +125,3 @@
     virtual std::string getTypeAsString() const = 0;
-    virtual void makeTypedMatcher(MatcherOps &Ops) const = 0;
+    virtual void* makeTypedMatcher(MatcherOps &Ops) const = 0;
     virtual bool isConvertibleTo(ast_type_traits::ASTNodeKind Kind,
----------------
Is there a chance to get something out of this without handing around void*'s?

Have you tried splitting the registration up into multiple TUs, and what effect 
that has?

http://reviews.llvm.org/D5124



_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to