Thanks Aaron and Patrick! Makes sense to me. :-) I'm not sure Visited should be a field of Block at all, so I probably want to remove those in the next patch anyway.
-DeLesley On Fri, Sep 12, 2014 at 5:56 AM, Aaron Ballman <[email protected]> wrote: > On Fri, Sep 12, 2014 at 8:51 AM, Patrik Hägglund H > <[email protected]> wrote: > > With gcc-4.9.1, I get: > > > > ../tools/clang/lib/Analysis/ThreadSafetyTIL.cpp:173:11: error: overflow > in implicit constant conversion [-Werror=overflow] > > Visited = 1; > > ^ > > Should unsigned be used instead of int below? > > I just fixed this in r217670 -- I changed to using a bool instead of > unsigned, since bool is all this is meant to represent anyway. > > ~Aaron > -- DeLesley Hutchins | Software Engineer | [email protected] | 505-206-0315
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
