================ Comment at: tools/clang/lib/CodeGen/CGClass.cpp:186 @@ +185,3 @@ + EmitTypeCheck(TCK_Upcast, Loc, Value, DerivedTy, DerivedAlign, + !NullCheckValue); + } ---------------- I am not sure that the `SkipNullCheck` behavior here is right. If `NullCheckValue` is false, then I think we should be performing a null check inside `EmitTypeCheck` rather than assuming the pointer is non-null.
http://reviews.llvm.org/D5635 _______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
