Is a CompoundStatement's start/end loc ever different from lbrace/rbrace
location? (maybe when it's a compound statement without braces? But that
can never occur in this part of the AST, right) If it isn't, then the
if/else LBrace/RBrace bit could be omitted. Maybe then we could just remove
the "if CompoundStatement" bit entirely? (or check that it's not a
defaulted definition, etc? Not sure what else might appear here in the AST)

On Wed, Oct 22, 2014 at 1:37 PM, Aaron Ballman <[email protected]>
wrote:

> Details, details! ;-) It was trivial, but not THAT trivial -- thanks,
> David!
>
> ~Aaron
>
> On Wed, Oct 22, 2014 at 4:34 PM, David Blaikie <[email protected]> wrote:
> > (missing patch attachment)
> >
> > On Wed, Oct 22, 2014 at 1:29 PM, Aaron Ballman <[email protected]>
> > wrote:
> >>
> >> Currently, function try blocks are not analyzed to determine whether
> >> all control paths return a value. This patch addresses that, and adds
> >> test cases for it. This appears to be a relatively simple change
> >> required to support this.
> >>
> >> ~Aaron
> >> _______________________________________________
> >> cfe-commits mailing list
> >> [email protected]
> >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >
> >
>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to