This generally looks great, thanks. I'm thinking we should probably split the
rename of refersToEnclosingLocal -> refersToCapturedVariable into a separate
patch, though.
================
Comment at: lib/CodeGen/CGExpr.cpp:1905
@@ +1904,3 @@
+ else if (CapturedStmtInfo) {
+ if (auto *FD = CapturedStmtInfo->lookup(VD)) {
+ if (auto *V = LocalDeclMap.lookup(VD))
----------------
It's possible to fall out of this entire block if CapturedStmtInfo->lookup(VD)
fails. Is that expected to be possible? If not, you should have an assertion
here. If it is, I don't know what you want to do, but there should at least be
a comment explaining why this is possible.
http://reviews.llvm.org/D6259
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
